-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A veritable deluge of commas #35714
Open
orangejenny
wants to merge
18
commits into
master
Choose a base branch
from
jls/so-many-commas-5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
A veritable deluge of commas #35714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
requested review from
biyeun,
esoergel,
MartinRiese,
AddisonDunn,
stephherbers,
Robert-Costello and
Jtang-1
as code owners
January 30, 2025 20:30
dimagimon
added
the
Risk: High
Change affects files that have been flagged as high risk.
label
Jan 30, 2025
dimagimon
added
the
Risk: Medium
Change affects files that have been flagged as medium risk.
label
Jan 30, 2025
orangejenny
removed
the
Risk: High
Change affects files that have been flagged as high risk.
label
Jan 30, 2025
MartinRiese
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
product/invisible
Change has no end-user visible impact
Risk: Medium
Change affects files that have been flagged as medium risk.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
See #35707
This is the last one. I haven't done the full codebase, but I've gotten most of it.
Safety Assurance
Safety story
Safe, automated changes from running eslint with the
--fix
option.Automated test coverage
not really
QA Plan
no
Rollback instructions
Labels & Review