Added explicit dependencies to ui-element-key-val-mapping #35718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
approved these changes
Jan 31, 2025
| return hqImport('hqwebapp/js/ui_elements/bootstrap3/ui-element-key-val-mapping').new(options); | ||
| }; | ||
|
|
||
| module.serialize = function (obj) { |
There was a problem hiding this comment.
Was this unused? I didn't see anywhere where it is replaced in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This is cherry-picked from the webpack migration for app manager. The rest of these widgets are used in other places and already declare their dependencies in the
hqDefinecall, butui-element-key-val-mappingis apparently only used in app manager.I also removed the overarching
ui-element.jsfile that groups all of these widgets together. We don't use these widgets that widely, they don't need to be included as a unit. Including single widgets is how we handle other widget libraries (jquery ui, ko components).Safety Assurance
Safety story
Tested locally that the icon mapping works in case detail. Smoke tested id mappings, inputs, and selects in case detail for good measure.
Automated test coverage
doubt it
QA Plan
Not requesting QA.
Rollback instructions
Labels & Review