Allow customizing the schedule with FixedUpdate #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should've made this a draft, shouldn't merge this until 0.11 as it isn't currently possible to use |
|
Thank you for this PR! Based on your comment I converted it to a draft. Feel free to un-draft it once it’s ready with bevy 0.11. |
Aceeri
commented
Jul 29, 2023
Comment on lines
+238
to
+247
| // Warn user if the timestep mode isn't in Fixed | ||
| if self.schedule.as_dyn_eq().dyn_eq(FixedUpdate.as_dyn_eq()) { | ||
| let config = app.world.resource::<RapierConfiguration>(); | ||
| match config.timestep_mode { | ||
| TimestepMode::Fixed { .. } => {} | ||
| mode => { | ||
| warn!("TimestepMode is set to `{:?}`, it is recommended to use `TimestepMode::Fixed` if you have the physics in `FixedUpdate`", mode); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we automatically set it to fixed here?
There was a problem hiding this comment.
I’m fine with the warning for now.
|
Thanks! I just renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355
Adds common usage of plugin to adding to
FixedUpdate, otherwise the simulation will run too fast in the scenario that we run based onTimestepMode::Fixed.