Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
bevy_rapier
copies a lot of code fromrapier
, only to change a few signature functions for better glam compatibility.In my opinion, wrapper types should be simpler: we should thrive to expose rapier types and limit code duplication:
Advantages of this approach:
joint_conversion_methods!
should only live inrapier
.rapier
's functionalities should be oriented towardrapier
's documentation, notbevy_rapier
. The community would be able to better exchange on different features with a lower "wrapper overhead"Ultimately, I think if should be possible to expose traits for
glam
(andnalgebra
?) capabilities, but that probably needs a more holistic approach with invasive (but I believe they could be made almost invisible) to rapier and rapier users.Example to illustrate trait types for different library crates:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=5d57dccf5c175f862a20dbcdda149d58