Split RapierContext

CHANGELOG.md

@@ -23,16 +23,23 @@ which was its hardcoded behaviour.
 
 ### Modified
 
-- `RapierContext`, `RapierConfiguration` and `RenderToSimulationTime` are now a `Component` instead of resources.
-  - Rapier now supports multiple independent physics worlds, see example `multi_world3` for usage details.
-  - Migration guide:
-    - `ResMut<mut RapierContext>` -> `WriteDefaultRapierContext`
-    - `Res<RapierContext>` -> `ReadDefaultRapierContext`
-    - Access to `RapierConfiguration` and `RenderToSimulationTime` should query for it
-on the responsible entity owning the `RenderContext`.
-  - If you are building a library on top of `bevy_rapier` and would want to support multiple independent physics worlds too,
-you can check out the details of [#545](https://github.com/dimforge/bevy_rapier/pull/545)
-to get more context and information.
+- Rapier now supports multiple independent physics worlds, see example `multi_world3` for usage details.
+  - `RapierContext` is no longer a resource: it has been split in multiple `Component`s:
+    - `RapierContextColliders`
+    - `RapierContextJoints`
+    - `RapierContextSimulation`
+    - `RapierRigidBodySet`
+  - Each entity managed by bevy_rapier has a `RapierContextEntityLink` pointing to the entity containing the components above.
+  - `RapierContext` was reworked to be a `SystemParam`, to help with migration. See `ray_casting` examples for a usage example.
+  - `RapierConfiguration` and `RenderToSimulationTime` are now `Component`s instead of resources.
+    - Migration guide:
+      - `ResMut<mut RapierContext>` -> `WriteRapierContext`
+      - `Res<RapierContext>` -> `ReadRapierContext`
+      - Access to `RapierConfiguration` and `RenderToSimulationTime` should query for it
+  on the responsible entity owning the `RenderContext`.
+    - If you are building a library on top of `bevy_rapier` and would want to support multiple independent physics worlds too,
+  you can check out the details of [#545](https://github.com/dimforge/bevy_rapier/pull/545)
+  to get more context and information.
 
 ## v0.27.0 (07 July 2024)
 

bevy_rapier2d/examples/testbed2.rs

@@ -204,11 +204,12 @@ fn main() {
             OnExit(Examples::PlayerMovement2),
             (
                 cleanup,
-                |mut rapier_config: Query<&mut RapierConfiguration>,
-                 ctxt: ReadDefaultRapierContext| {
+                |mut rapier_config: Query<&mut RapierConfiguration>, ctxt: ReadRapierContext| {
                     let mut rapier_config = rapier_config.single_mut();
-                    rapier_config.gravity =
-                        RapierConfiguration::new(ctxt.integration_parameters.length_unit).gravity;
+                    rapier_config.gravity = RapierConfiguration::new(
+                        ctxt.single().simulation.integration_parameters.length_unit,
+                    )
+                    .gravity;
                 },
             ),
         )

bevy_rapier3d/examples/joints3.rs

@@ -284,7 +284,7 @@ pub fn setup_physics(mut commands: Commands) {
 }
 
 pub fn print_impulse_revolute_joints(
-    context: ReadDefaultRapierContext,
+    context: ReadRapierContext,
     joints: Query<(Entity, &ImpulseJoint)>,
 ) {
     for (entity, impulse_joint) in joints.iter() {
@@ -293,7 +293,7 @@ pub fn print_impulse_revolute_joints(
                 println!(
                     "angle for {}: {:?}",
                     entity,
-                    context.impulse_revolute_joint_angle(entity),
+                    context.single().impulse_revolute_joint_angle(entity),
                 );
             }
             _ => {}

bevy_rapier3d/examples/multi_world3.rs

@@ -30,7 +30,7 @@ fn main() {
 
 fn create_worlds(mut commands: Commands) {
     for i in 0..N_WORLDS {
-        let mut world = commands.spawn((RapierContext::default(), WorldId(i)));
+        let mut world = commands.spawn((RapierContextSimulation::default(), WorldId(i)));
         if i == 0 {
             world.insert(DefaultRapierContext);
         }
@@ -75,7 +75,7 @@ fn change_world(
 }
 
 pub fn setup_physics(
-    context: Query<(Entity, &WorldId), With<RapierContext>>,
+    context: Query<(Entity, &WorldId), With<RapierContextSimulation>>,
     mut commands: Commands,
 ) {
     for (context_entity, id) in context.iter() {

bevy_rapier3d/examples/ray_casting3.rs

@@ -76,7 +76,7 @@ pub fn setup_physics(mut commands: Commands) {
 pub fn cast_ray(
     mut commands: Commands,
     windows: Query<&Window, With<PrimaryWindow>>,
-    rapier_context: ReadDefaultRapierContext,
+    rapier_context: ReadRapierContext,
     cameras: Query<(&Camera, &GlobalTransform)>,
 ) {
     let window = windows.single();
@@ -91,9 +91,9 @@ pub fn cast_ray(
         let Some(ray) = camera.viewport_to_world(camera_transform, cursor_position) else {
             return;
         };
-
+        let context = rapier_context.single();
         // Then cast the ray.
-        let hit = rapier_context.cast_ray(
+        let hit = context.cast_ray(
             ray.origin,
             ray.direction.into(),
             f32::MAX,

bevy_rapier_benches3d/src/lib.rs

@@ -9,7 +9,7 @@ use common::default_app;
 use common::wait_app_start;
 
 use bevy::prelude::*;
-use bevy_rapier3d::plugin::RapierContext;
+use bevy_rapier3d::plugin::context::RapierContextSimulation;
 
 pub fn custom_bencher(steps: usize, setup: impl Fn(&mut App)) {
     let mut app = default_app();
@@ -28,7 +28,7 @@ pub fn custom_bencher(steps: usize, setup: impl Fn(&mut App)) {
         let elapsed_time = timer_full_update.time() as f32;
         let rc = app
             .world_mut()
-            .query::<&RapierContext>()
+            .query::<&RapierContextSimulation>()
             .single(app.world());
         rapier_step_times.push(rc.pipeline.counters.step_time.time() as f32);
         total_update_times.push(elapsed_time);

src/control/character_controller.rs

@@ -2,7 +2,7 @@ use crate::geometry::{Collider, CollisionGroups, ShapeCastHit};
 use crate::math::{Real, Rot, Vect};
 use bevy::prelude::*;
 
-use crate::plugin::RapierContext;
+use crate::plugin::context::RapierContextColliders;
 pub use rapier::control::CharacterAutostep;
 pub use rapier::control::CharacterLength;
 use rapier::prelude::{ColliderSet, QueryFilterFlags};
@@ -26,7 +26,7 @@ pub struct CharacterCollision {
 
 impl CharacterCollision {
     pub(crate) fn from_raw(
-        ctxt: &RapierContext,
+        ctxt: &RapierContextColliders,
         c: &rapier::control::CharacterCollision,
     ) -> Option<Self> {
         Self::from_raw_with_set(&ctxt.colliders, c, true)
@@ -37,7 +37,7 @@ impl CharacterCollision {
         c: &rapier::control::CharacterCollision,
         details_always_computed: bool,
     ) -> Option<Self> {
-        RapierContext::collider_entity_with_set(colliders, c.handle).map(|entity| {
+        RapierContextColliders::collider_entity_with_set(colliders, c.handle).map(|entity| {
             CharacterCollision {
                 entity,
                 character_translation: c.character_pos.translation.vector.into(),

src/dynamics/revolute_joint.rs

@@ -1,11 +1,14 @@
 use crate::dynamics::{GenericJoint, GenericJointBuilder};
 use crate::math::{Real, Vect};
-use crate::plugin::RapierContext;
+use crate::plugin::context::RapierRigidBodySet;
 use bevy::prelude::Entity;
 use rapier::dynamics::{
     JointAxesMask, JointAxis, JointLimits, JointMotor, MotorModel, RigidBodyHandle, RigidBodySet,
 };
 
+#[cfg(doc)]
+use crate::prelude::RapierContext;
+
 use super::TypedJoint;
 
 #[cfg_attr(feature = "serde-serialize", derive(Serialize, Deserialize))]
@@ -147,7 +150,7 @@ impl RevoluteJoint {
     /// Similarly [`RapierContext::impulse_revolute_joint_angle`] only takes a single entity as argument to compute that angle.
     ///
     /// # Parameters
-    /// - `bodies` : the rigid body set from [`RapierContext`]
+    /// - `bodies` : the rigid body set from [`RapierRigidBodySet`]
     /// - `body1`: the first rigid-body attached to this revolute joint, obtained through [`rapier::dynamics::ImpulseJoint`] or [`rapier::dynamics::MultibodyJoint`].
     /// - `body2`: the second rigid-body attached to this revolute joint, obtained through [`rapier::dynamics::ImpulseJoint`] or [`rapier::dynamics::MultibodyJoint`].
     pub fn angle_from_handles(
@@ -167,13 +170,13 @@ impl RevoluteJoint {
     /// The angle along the free degree of freedom of this revolute joint in `[-π, π]`.
     ///
     /// # Parameters
-    /// - `bodies` : the rigid body set from [`RapierContext`]
+    /// - `bodies` : the rigid body set from [`RapierRigidBodySet`]
     /// - `body1`: the first rigid-body attached to this revolute joint.
     /// - `body2`: the second rigid-body attached to this revolute joint.
-    pub fn angle(&self, context: &RapierContext, body1: Entity, body2: Entity) -> f32 {
-        let rb1 = context.entity2body().get(&body1).unwrap();
-        let rb2 = context.entity2body().get(&body2).unwrap();
-        self.angle_from_handles(&context.bodies, *rb1, *rb2)
+    pub fn angle(&self, rigidbody_set: &RapierRigidBodySet, body1: Entity, body2: Entity) -> f32 {
+        let rb1 = rigidbody_set.entity2body().get(&body1).unwrap();
+        let rb2 = rigidbody_set.entity2body().get(&body2).unwrap();
+        self.angle_from_handles(&rigidbody_set.bodies, *rb1, *rb2)
     }
 }
 

src/lib.rs

@@ -72,6 +72,8 @@ pub mod prelude {
     pub use crate::geometry::*;
     pub use crate::math::*;
     pub use crate::pipeline::*;
+    pub use crate::plugin::context::systemparams::*;
+    pub use crate::plugin::context::*;
     pub use crate::plugin::*;
     #[cfg(any(feature = "debug-render-3d", feature = "debug-render-2d"))]
     pub use crate::render::*;

src/pipeline/events.rs

@@ -182,7 +182,7 @@ mod test {
             ));
             // 2 seconds should be plenty of time for the cube to fall on the
             // lowest collider.
-            for _ in 0..120 {
+            for _ in 0..1020 {
                 app.update();
             }
             let saved_collisions = app

src/pipeline/query_filter.rs

@@ -5,7 +5,7 @@ pub use rapier::pipeline::QueryFilterFlags;
 use crate::geometry::CollisionGroups;
 
 #[cfg(doc)]
-use crate::prelude::RapierContext;
+use crate::prelude::{RapierContext, RapierContextSimulation};
 
 /// A filter that describes what collider should be included or excluded from a scene query.
 ///

src/plugin/configuration.rs

@@ -1,3 +1,5 @@
+//! Components used to configure a simulation run by rapier, these are not modified by bevy_rapier.
+
 use bevy::{
     prelude::{Component, Resource},
     reflect::Reflect,
@@ -8,13 +10,6 @@ use crate::math::{Real, Vect};
 #[cfg(doc)]
 use {crate::prelude::TransformInterpolation, rapier::dynamics::IntegrationParameters};
 
-/// Difference between simulation and rendering time
-#[derive(Component, Default, Reflect)]
-pub struct SimulationToRenderTime {
-    /// Difference between simulation and rendering time
-    pub diff: f32,
-}
-
 /// The different ways of adjusting the timestep length each frame.
 #[derive(Copy, Clone, Debug, PartialEq, Resource)]
 pub enum TimestepMode {