Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please implement Vector<T> From<Point<T>> trait #1450

Open
MillieFD opened this issue Oct 21, 2024 · 1 comment
Open

Please implement Vector<T> From<Point<T>> trait #1450

MillieFD opened this issue Oct 21, 2024 · 1 comment
Labels
enhancement good first issue Good first issue for newcomers.

Comments

@MillieFD
Copy link

The From<Point3<T>> trait is not currently implemented for the Vector3<T> struct. Attempting to add this implementation in my own code causes complier error E0117 (Only traits defined in the current crate can be implemented for arbitrary types). It is therefore necessary to implement this From trait at source.

As the Point struct is based on the Vector struct, this should be very easy to implement.

@sebcrozet sebcrozet added enhancement good first issue Good first issue for newcomers. labels Oct 26, 2024
@sebcrozet
Copy link
Member

This looks like a reasonable addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good first issue for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants