Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement From<Point<T>> for Vector<T> #1460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement From<Point<T>> for Vector<T> #1460

wants to merge 1 commit into from

Conversation

jnyfah
Copy link
Contributor

@jnyfah jnyfah commented Nov 9, 2024

This PR addresses issue #1450

Changes made:

  1. Restricted the existing homogeneous conversion to specific 2D/3D cases

    • Point2 -> Vector3 (homogeneous)
    • Point3 -> Vector4 (homogeneous)

  2. Added generic dimension-preserving conversion

  3. Added tests for both conversion types

@jnyfah jnyfah marked this pull request as ready for review November 9, 2024 15:34
@Andlon Andlon added the breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnyfah @Andlon