Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize MSSQL library when used #1553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michivi
Copy link

@michivi michivi commented Jan 16, 2024

This PR changes pgloader's behavior so that it properly initialize freetds (through cl-mssql) when working with a MS SQL Server database.

This PR relies on the functions introduced in archimag/cl-mssql#11 (merged at the time of writing).

Before this PR, pgloader uses freetds directly without initialization. While the database copy does happen, users will see several instances of the following message:

Max connections reached, increase value of TDS_MAX_CONN

This happens because the freetds was not initialized properly. This PR initializes the library when a SQL Server is used.

Fixes #1354

@svantevonerichsen6906
Copy link
Collaborator

The debian build doesn't seem to have or pull the new cl-mssql (doesn't find the new init symbol).

@michivi
Copy link
Author

michivi commented Jan 17, 2024

This build issue comes from the fact that this change requires the latest version of cl-mssql, more specifically, this specific PR. That PR was only merged yesterday. So I guess, it's expected since the CI job downloads the official cl-mssql version from the Debian repository. So I guess that unfortunately, it means we'd have to wait for cl-mssql to be updated there?

@bedaes
Copy link

bedaes commented Jul 19, 2024

Hi! I'm interested in getting this merged. From what I understand all that's missing is re-triggering the debian-build action and hoping that a recent enough cl-mssql version gets downloaded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pgloader - MSSQL to Postgres (YB) throwing TDS_MAX_CONN error
3 participants