Merge pull request #158 from lucasmichot/conditional-request

[Bugfix] : Disable conditional request feature outside API and does not overwrite existing ETag
dingo · Aug 19, 2014 · e19389d · e19389d
2 parents f1e3f2f + a5d8b46
commit e19389d
Show file tree

Hide file tree

Showing 2 changed files with 117 additions and 8 deletions.
diff --git a/src/Routing/Router.php b/src/Routing/Router.php
@@ -287,15 +287,21 @@ protected function prepareResponse($request, $response)
     {
         $response = parent::prepareResponse($request, $response);
 
-        if ($response instanceof IlluminateResponse && $this->requestTargettingApi($request)) {
-            $response = ApiResponse::makeFromExisting($response);
-        }
+        if ($this->requestTargettingApi($request)) {
 
-        if ($response->isSuccessful() && $this->getConditionalRequest()) {
-            $response->setEtag(md5($response->getContent()));
-        }
+            if ($response instanceof IlluminateResponse) {
+                $response = ApiResponse::makeFromExisting($response);
+            }
 
-        $response->isNotModified($request);
+            if ($response->isSuccessful() && $this->getConditionalRequest()) {
+
+                if (! $response->headers->has('ETag')) {
+                    $response->setEtag(md5($response->getContent()));
+                }
+
+                $response->isNotModified($request);
+            }
+        }
 
         return $response;
     }

diff --git a/tests/RoutingRouterTest.php b/tests/RoutingRouterTest.php
@@ -148,7 +148,7 @@ public function testAddingRouteFallsThroughToRouterCollection()
 	}
 
 
-    public function testRouterPreparesNotModifiedResponse()
+    public function testRouterPreparesNotModifiedIlluminateResponse()
     {
         $this->router->api(['version' => 'v1'], function ()
         {
@@ -190,6 +190,109 @@ public function testRouterPreparesNotModifiedResponse()
     }
 
 
+    public function testRouterPreparesNotModifiedNonIlluminateResponse()
+    {
+        $this->router->api(['version' => 'v1'], function ()
+        {
+            $this->router->get('foo', function () {
+                return new \Symfony\Component\HttpFoundation\Response('bar');
+            });
+        });
+
+        $request = Request::create('foo', 'GET');
+        $request->headers->set('accept', 'application/vnd.testing.v1+json');
+        $this->router->setConditionalRequest(false);
+        $response = $this->router->dispatch($request);
+        $this->assertEquals(200, $response->getStatusCode());
+        $this->assertEquals('bar', $response->getContent());
+
+        $request = Request::create('foo', 'GET');
+        $request->headers->set('accept', 'application/vnd.testing.v1+json');
+        $this->router->setConditionalRequest(true);
+        $response = $this->router->dispatch($request);
+        $this->assertEquals(200, $response->getStatusCode());
+        $this->assertEquals('"'.md5('bar').'"', $response->getETag());
+        $this->assertEquals('bar', $response->getContent());
+
+        $request = Request::create('foo', 'GET');
+        $request->headers->set('If-None-Match', '"'.md5('bar').'"', true);
+        $request->headers->set('accept', 'application/vnd.testing.v1+json');
+        $this->router->setConditionalRequest(true);
+        $response = $this->router->dispatch($request);
+        $this->assertEquals(304, $response->getStatusCode());
+        $this->assertEquals('"'.md5('bar').'"', $response->getETag());
+        $this->assertEquals(null, $response->getContent());
+
+        $request = Request::create('foo', 'GET');
+        $request->headers->set('If-None-Match', '0123456789', true);
+        $request->headers->set('accept', 'application/vnd.testing.v1+json');
+        $this->router->setConditionalRequest(true);
+        $response = $this->router->dispatch($request);
+        $this->assertEquals(200, $response->getStatusCode());
+        $this->assertEquals('"'.md5('bar').'"', $response->getETag());
+        $this->assertEquals('bar', $response->getContent());
+    }
+
+
+    public function testRouterSkipNotModifiedResponseOutsideApi()
+    {
+        $this->router->group([], function ()
+        {
+            $this->router->get('foo', function () { return 'bar'; });
+        });
+
+        $request = Request::create('foo', 'GET');
+        $this->router->setConditionalRequest(true);
+        $response = $this->router->dispatch($request);
+        $this->assertEquals(200, $response->getStatusCode());
+        $this->assertFalse($response->headers->has('ETag'));
+        $this->assertEquals('bar', $response->getContent());
+    }
+
+
+    public function testRouterHandlesExistingEtag()
+    {
+        $this->router->api(['version' => 'v1'], function ()
+        {
+            $this->router->get('foo', function () {
+                $response = new Response('bar');
+                $response->setEtag('custom-etag');
+                return $response;
+            });
+        });
+
+        $request = Request::create('foo', 'GET');
+        $request->headers->set('accept', 'application/vnd.testing.v1+json');
+        $this->router->setConditionalRequest(true);
+        $response = $this->router->dispatch($request);
+        $this->assertEquals(200, $response->getStatusCode());
+        $this->assertEquals('"custom-etag"', $response->getETag());
+        $this->assertEquals('bar', $response->getContent());
+    }
+
+
+    public function testRouterHandlesCustomEtag()
+    {
+        $this->router->api(['version' => 'v1'], function ()
+        {
+            $this->router->get('foo', function () {
+                $response = new Response('bar');
+                $response->setEtag('custom-etag');
+                return $response;
+            });
+        });
+
+        $request = Request::create('foo', 'GET');
+        $request->headers->set('If-None-Match', '"custom-etag"', true);
+        $request->headers->set('accept', 'application/vnd.testing.v1+json');
+        $this->router->setConditionalRequest(true);
+        $response = $this->router->dispatch($request);
+        $this->assertEquals(304, $response->getStatusCode());
+        $this->assertEquals('"custom-etag"', $response->getETag());
+        $this->assertEquals(null, $response->getContent());
+    }
+
+
 	public function testGettingUnkownApiCollectionThrowsException()
 	{
 		$this->assertNull($this->router->getApiRouteCollection('v1'));