don't call key edit on uneaten key when not composing

skype crashes if RequestEditSession is called when its Alt menu is active
dinhngtu · Dec 19, 2020 · 4672d74 · 4672d74
1 parent 974cdc1
commit 4672d74
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/VietTypeATL/KeyEventSink.cpp b/VietTypeATL/KeyEventSink.cpp
@@ -151,8 +151,10 @@ STDMETHODIMP KeyEventSink::OnKeyDown(_In_ ITfContext* pic, _In_ WPARAM wParam, _
 
     DBG_DPRINT(L"OnKeyDown wParam = %lx %s", wParam, *pfEaten ? L"eaten" : L"not eaten");
 
-    hr = CallKeyEdit(pic, wParam, lParam, _keyState);
-    HRESULT_CHECK_RETURN(hr, L"%s", L"CallKeyEdit failed");
+    if (*pfEaten || _compositionManager->IsComposing()) {
+        hr = CallKeyEdit(pic, wParam, lParam, _keyState);
+        HRESULT_CHECK_RETURN(hr, L"%s", L"CallKeyEdit failed");
+    }
 
     return S_OK;
 }