feat: add sandbox option #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makhnatkin
reviewed
Feb 11, 2025
makhnatkin
reviewed
Feb 13, 2025
| setClassNames = (classNames: string[] | undefined = []) => { | ||
| updateClassNames(this.domContainer, classNames, this.classNames); | ||
|
|
||
| // update this._classNames to the new classNames |
There was a problem hiding this comment.
In my opinion, these comments are redundant, lets delete it
| setStyles = (styles: Record<string, string> | undefined = {}) => { | ||
| updateStyles(this.domContainer, styles, this.styles); | ||
|
|
||
| // update this._styles to the new styles |
There was a problem hiding this comment.
In my opinion, these comments are redundant, lets delete it
|
|
||
| this.domContainer.replaceChildren(fragment); | ||
|
|
||
| // TODO: should we reinitialize Observer? |
There was a problem hiding this comment.
The comment does not give an understanding of why, let's add more context.
There was a problem hiding this comment.
All these comments are from the original class IFrameController, I can just delete them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
sandboxoption for thesrcdocmode, which allows you to enable additional security levels (thesandboxattribute on the iframe).Fixes #59