Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the hyak stamp build scripts + refactor #12

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

maxwest-uw
Copy link
Collaborator

Change Description

Takes the (refactored) build scripts and puts them in a new /scripts directory so that we can have a nice version controlled version of them :)

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@maxwest-uw maxwest-uw requested a review from drewoldag January 24, 2025 00:04
Copy link
Contributor

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine overall. I did leave one file-level comment that's just a request, but doesn't indicate a blocker.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places in this script where some sorta mysterious values are being passed to external functions. I have to believe that they are doing what is expected, but it's not exactly clear what they are doing. Specifically lines 70 and 84. I'm guessing that those functions have required parameters, but what's not clear is whether those inputs affect the output in a meaningful way.

A comment about those values would be nice if they are just placeholders.

@maxwest-uw maxwest-uw merged commit 5770a22 into main Jan 27, 2025
2 of 8 checks passed
@maxwest-uw maxwest-uw deleted the stamp_scripts branch January 27, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants