Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefactoring: Rename and move interfaces #341

Merged
merged 11 commits into from
Sep 18, 2023
Merged

Prefactoring: Rename and move interfaces #341

merged 11 commits into from
Sep 18, 2023

Conversation

jeremykubica
Copy link
Contributor

This is an initial set of changes to prepare for the ImageStack redesign, including:

  • Use a consistent name (obstime) throughout the stack for the time of observation.
  • Move the storage of the observation time from LayeredImage to RawImage.
  • Change PPI to NPixels throughout the stack.
  • Move the majority of FITS file reading into RawImage, adding convenience functions for appending layers, reading in an image from a specific layer, and write a single layer file.
  • Write out per-image timestamps (instead of a single one per LayeredImage)
  • Add more tests for file io.

Copy link
Member

@DinoBektesevic DinoBektesevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confused as to what naming convention we're using - but that's job for a different day.

Feels pretty good to finally sort these annoyances out.

@jeremykubica jeremykubica merged commit 343af9b into main Sep 18, 2023
1 check passed
@jeremykubica jeremykubica deleted the prefactor branch September 18, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants