Revamp the interface for timestamps #351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #350
Previously KBMOD stored the timestamps in multiple locations, providing the potential for out of sync data or other errors (especially as we allow changes at the
RawImage
level). This PR consolidates all of the timestamp storage in a single location. Specific aspects include:ImageStack
. This could easily get out of date.ImageStack
. Make them clearly named in terms of what they return.ImageStack
(at linear cost). This is used in a few locations in the search stack and tests.Note that this PR involves a tradeoff of extra computing time in a few cases to avoid carrying around multiple copies of the timestamps.