Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial transliteration of RawImage to an Eigen backend. #364

Merged
merged 37 commits into from
Nov 2, 2023
Merged

Initial transliteration of RawImage to an Eigen backend. #364

merged 37 commits into from
Nov 2, 2023

Commits on Oct 24, 2023

  1. Initial transliteration of RawImage to an Eigen backend.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fe75f09 View commit details
    Browse the repository at this point in the history

  2. Remove accidentally committed file.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c0d271f View commit details
    Browse the repository at this point in the history

  3. Try to fix the eigen submodule.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2eeb773 View commit details
    Browse the repository at this point in the history

  4. Try to remove the submodule and re-add it.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c8615bc View commit details
    Browse the repository at this point in the history

  5. Add Eigen submodule back in.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3564ccd View commit details
    Browse the repository at this point in the history

  6. Remove accidentally commited binary.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    36884c6 View commit details
    Browse the repository at this point in the history

  7. Fix interpolate methods.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    234cc88 View commit details
    Browse the repository at this point in the history

  8. Address Index constructors comments.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    03623ee View commit details
    Browse the repository at this point in the history

  9. Revert grow_mask to previous implementation

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5ed10af View commit details
    Browse the repository at this point in the history

  10. Remove create_median_image_eigen2 test func.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d65457e View commit details
    Browse the repository at this point in the history

  11. Remove create_median_image_eigen2, interpolate and rename interpolate… 

    …2. Remove unused centered_block with no edge-checking.
    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9bb6047 View commit details
    Browse the repository at this point in the history

  12. Remove old getters and setters.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c577fee View commit details
    Browse the repository at this point in the history

  13. Move is_within to RawImage, fix missing call to centered_block.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    37c9936 View commit details
    Browse the repository at this point in the history

  14. Revert image back to private attribute. 

    Moved everything back to private attribute.
Added previously removed getters and setters.
Added bindings for new getters and setters.
Added bindings for Index.
Add tests for Eigen Raw Image.
    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e94aa4f View commit details
    Browse the repository at this point in the history

  15. Flakify.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f419b02 View commit details
    Browse the repository at this point in the history

  16. Add check when psf_portion==0 in convolve.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2a48292 View commit details
    Browse the repository at this point in the history

  17. Use a nested for loop for apply_mask.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    23efd44 View commit details
    Browse the repository at this point in the history

  18. Add 'exclude*' prefix to gitignore.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e2f9438 View commit details
    Browse the repository at this point in the history

  19. Cleanup Index and Point.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    01c743d View commit details
    Browse the repository at this point in the history

  20. Clean up the declarations of namespace py.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e8d6fe1 View commit details
    Browse the repository at this point in the history

  21. Merge raw_image_eigen into codebase, fix tests.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d7e644f View commit details
    Browse the repository at this point in the history

  22. Update the new code to fit the eigen transition, fix more tests.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    14caac8 View commit details
    Browse the repository at this point in the history

  23. Fix last of the tests, update analysis_utils.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9a14c27 View commit details
    Browse the repository at this point in the history

  24. Clang and flakify.

    @DinoBektesevic
    DinoBektesevic committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1ab7772 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Fix for loop limits in raw image apply_mask.

    @DinoBektesevic
    DinoBektesevic committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    4696483 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. Add tests for geom.h. Improve bindings. 

    Consistently handle all the various Cartesian vs indexing notation.
Add tests for structs and functions in geom.h.
Add bindings for missing functions.
Improve bindings for Index and Point.
  - add comparison operators for Index==Index and Index==tuple
  - add comparion operators for Point==Point and Point==tuple
  - add casting to numpy structured arrays.
  - add constructors for Point
Improve AnchoredRectangle:
  - rename to Rectangle
  - add constructors to enable use as Rectangle
  - anchor is a consequence of how we treat stamps (2r+1) and
    can be generalized, but that's a different PR. Treat that
    as implementation detail for now.
Add comments, improve code readability.
Clang and flakify.
    @DinoBektesevic
    DinoBektesevic committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    331ba8b View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Add documentation.

    @DinoBektesevic
    DinoBektesevic committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    40c4a2f View commit details
    Browse the repository at this point in the history

  2. Use Point vs Index more consistently in the codebase.

    @DinoBektesevic
    DinoBektesevic committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    1bacda6 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Clean the mess and confusion in kernels.cu

    @DinoBektesevic
    DinoBektesevic committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f49395a View commit details
    Browse the repository at this point in the history

  2. Raise error in set_pixel, inline more accessors, respond to more revi… 

    …ew comments.
    @DinoBektesevic
    DinoBektesevic committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    312e74d View commit details
    Browse the repository at this point in the history

  3. Cleanup more of the code comments.

    @DinoBektesevic
    DinoBektesevic committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b1cf112 View commit details
    Browse the repository at this point in the history

  4. clang-format and blacken.

    @DinoBektesevic
    DinoBektesevic committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ff716a2 View commit details
    Browse the repository at this point in the history

  5. Add obstime test to workunit.

    @DinoBektesevic
    DinoBektesevic committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3462cd5 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Increase velocity error tolerance in test_search. 

    Search produces 3 nearly identical results to within a pixel.
Different gcc/g++/nvcc versions sorting algorithm produce different
sorting of the results. This is version dependent as they are all
correctly sorted, as per the likelihood which is equal for the results.
    @DinoBektesevic
    DinoBektesevic committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    daf3b09 View commit details
    Browse the repository at this point in the history

  2. Update RawImage documentation.

    @DinoBektesevic
    DinoBektesevic committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d988c87 View commit details
    Browse the repository at this point in the history

  3. Update src/kbmod/search/pydocs/geom_docs.h 

    Fix spelling mistake in geom_docs

Co-authored-by: Jeremy Kubica <[email protected]>
    @DinoBektesevic @jeremykubica
    DinoBektesevic and jeremykubica authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    fd8b0f1 View commit details
    Browse the repository at this point in the history

  4. Fix comments and clarify docs.

    @DinoBektesevic
    DinoBektesevic committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c443edb View commit details
    Browse the repository at this point in the history