Mechanical application of clang-format #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delucchi-cmu
approved these changes
Oct 12, 2023
|
|
||
| const std::string to_yaml() const { | ||
| return "{x: " + std::to_string(x) + " y: " + std::to_string(y) + "}"; | ||
| return "{x: " + std::to_string(x) + " y: " + std::to_string(y) + "}"; |
There was a problem hiding this comment.
the to_yaml above uses a comma between fields. Would be nice to be consistent.
There was a problem hiding this comment.
I'm going to keep as-is for now to keep this a purely mechanical application of clang-format, but will change this in the next PR.
| " vx: " + std::to_string(vx) + | ||
| " vy: " + std::to_string(vy) + | ||
| " obs_count: " + std::to_string(obs_count); | ||
| return "lh: " + std::to_string(lh) + " flux: " + std::to_string(flux) + " x: " + std::to_string(x) + |
There was a problem hiding this comment.
This was a little easier to read in the original formatting (one field per line). Dunno about disabling code formatting for this block, though.
There was a problem hiding this comment.
Agreed that it was a little easier to read before. But I will keep it this way for now for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality changes.