Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkUnit Prefactoring #374

Merged
merged 7 commits into from
Oct 16, 2023
Merged

WorkUnit Prefactoring #374

merged 7 commits into from
Oct 16, 2023

Conversation

jeremykubica
Copy link
Contributor

This PR does a bunch of prep work before making run_search.py take a WorkUnit as an option. The goal here is to make that later PR simpler and more readable.

Changes include:

  • Remove Interface class from data_interface.py and add an option to load directly from the configuration file.
  • Add the ability for the FakeDataSet to save to a WorkUnit
  • Remove a bunch of unneeded parameters being passed to do_gpu_search
  • Instead of computing (and then possibly overwriting) suggested_angle keep the data in the configuration’s average_angle parameter and only overwrite if needed.
  • Move find_sigmaG_coeff out of PostProcess class and make it a standalone function.

Most of the diff lines are the result of removing the Interface class and the resulting changes in indentation.

@jeremykubica jeremykubica marked this pull request as ready for review October 13, 2023 15:56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

src/kbmod/run_search.py Show resolved Hide resolved
@jeremykubica jeremykubica merged commit 3a81020 into main Oct 16, 2023
1 check passed
@jeremykubica jeremykubica deleted the workunit2 branch October 16, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants