DRAFT PR for discussion #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonbb
reviewed
Oct 25, 2023
Comment on lines
-150
to
+151
| int current_x = x + int(curr_trj.vx * curr_time + 0.5); | ||
| int current_y = y + int(curr_trj.vy * curr_time + 0.5); | ||
| int current_x = x + (int)(floor(curr_trj.vx * curr_time)); | ||
| int current_y = y + (int)(floor(curr_trj.vy * curr_time)); |
There was a problem hiding this comment.
Minor question: From the earlier discussion, it seems the "+ 0.5" is used so that the int casting will round the result rather than truncate/floor it.
We should definitely be consistent about whichever we do, but out of curiosity is there a reason to prefer flooring over rounding?
There was a problem hiding this comment.
After writing that, I'm realizing that I shouldn't have used truncate/floor interchangeably since they are only equivalent operations for positive values, but I'm still curious about the round vs floor question
|
Closing this for now since the Eigen change went in. We can revisit pieces of this as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes several fundamental changes to the KBMOD core search:
floorinstead ofintto convert from predicted position to pixel index (matters for pixels off the negative side of the grid)