Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize and clean up helper functions for kernel testing #406

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

jeremykubica
Copy link
Contributor

@jeremykubica jeremykubica commented Dec 15, 2023

Move the sigmaGFilteredIndices which is only used to test the on-GPU implementation of sigmaG filtering into a better named file (filtering.cpp -> kernel_testing_helpers.cpp) to make it clear that this function only exists for testing purposes. This file also creates a single location where we can add more such testing functions in the future. Remove the filtering.cpp and filtering.h files as they did not end up being used outside that one testing use case. Removes the unused calculateLikelihoodFromPsiPhi function and its tests as well.

@jeremykubica jeremykubica merged commit 9d54136 into main Dec 15, 2023
2 checks passed
@jeremykubica jeremykubica deleted the filtering_cleanup branch December 15, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants