Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching doesn't cache #680

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Caching doesn't cache #680

merged 1 commit into from
Aug 6, 2024

Conversation

DinoBektesevic
Copy link
Member

I used row_index instead of std_idx to index standardizer cache list making the cache miss everytime.
Also packing of a single exposure packs the whole table which causes len(table) to be 0 instead of 1 in the unpack table function.

Thanks Drew!

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

@DinoBektesevic DinoBektesevic merged commit 5576fdf into main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants