Move Psi/Phi curve generation out of Python loop #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitosaurus
reviewed
Sep 18, 2024
jeremykubica
requested review from
drewoldag
and removed request for
maxwest-uw
drewoldag
reviewed
Sep 20, 2024
| self.assertTrue(np.all(phi_curves > 0.0)) | ||
|
|
||
| # Check that the batch getters give the same results as the iterative ones. | ||
| for i in range(self.num_objs): |
drewoldag
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the generation of the psi and phi curves from inside a Python loop to inside a C++ loop. This is a very small speedup, but also adds very little complexity.
This PR also:
test_search.pyby moving a few tests totest_stack_search_results.py