-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for LSSTCometActivity
class in community utils.
#4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have one variable hanging around that we can get rid of then it addreses dirac-institute/sorcha#501
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One variable i think we missed from moving all the nucleus calculations and also I think the code does not die gracefully if there is a user error
This PR includes all of the code that was pulled out of sorcha that supports
LSSTCometActivity
- namely the majority of the lsstcomet package, supporting tests and example notebooks.NOTE - I don't expect that the documentation notebooks will build right now - we need to wait until after the
sorcha
PR (dirac-institute/sorcha#508) merges and is published to pypi before finalizing this PR.resolves #3