Issue #6: Changing default aperture in lsst_comet_activity.py #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Closes #6. The default aperture used by lsst_comet_activity.py was set to the seeing. As per conversation with Colin Snodgrass outlined in the issue, using the seeing will cause comets to seem brighter at poorer seeing, which is obviously not the case.
Solution Description
I have simply changed the aperture to 1 arcsec. The user may feel free to change it to something larger at their own risk (lsstcomet assumes infinite coma, so large apertures will produce spurious results).
I have also updated the test.
Code Quality
Project-Specific Pull Request Checklists
Other Change Checklist