Changing default footprint_edge_threshold value

benchmarks/test_bench_config.ini

@@ -83,8 +83,8 @@ phase_function = HG
 camera_model = footprint
 
 # Path to camera footprint file. Uncomment to provide a path to the desired camera 
-# detector configurationn file if not using the default built-in LSSTCam detector 
-# configuration or not using the circle footprint model.
+# detector configuration file if not using the default built-in LSSTCam detector 
+# configuration for the actual camera footprint.
 # footprint_path= ./data/detectors_corners.csv
 
 # Fraction of detector surface area which contains CCD -- simulates chip gaps
@@ -97,8 +97,9 @@ camera_model = footprint
 # circle_radius = 1.75
 
 # The distance from the edge of a detector (in arcseconds on the focal plane)
-# at which we will not correctly extract an object.
-# footprint_edge_threshold = 0.0001
+# at which we will not correctly extract an object. By default this is 10px or 2 arcseconds.
+# Comment out or do not include if using footprint camera model.
+footprint_edge_threshold = 2.
 
 
 [FADINGFUNCTION]

src/sorcha/data/demo/sorcha_config_demo.ini

@@ -86,8 +86,8 @@ phase_function = HG
 camera_model = footprint
 
 # Path to camera footprint file. Uncomment to provide a path to the desired camera 
-# detector configurationn file if not using the default built-in LSSTCam detector 
-# configuration or not using the circle footprint model.
+# detector configuration file if not using the default built-in LSSTCam detector 
+# configuration for the actual camera footprint.
 # footprint_path= ./data/detectors_corners.csv
 
 # Fraction of detector surface area which contains CCD -- simulates chip gaps
@@ -100,8 +100,9 @@ camera_model = footprint
 # circle_radius = 1.75
 
 # The distance from the edge of a detector (in arcseconds on the focal plane)
-# at which we will not correctly extract an object.
-# footprint_edge_threshold = 0.0001
+# at which we will not correctly extract an object. By default this is 10px or 2 arcseconds.
+# Comment out or do not include if using footprint camera model.
+footprint_edge_threshold = 2.
 
 
 [FADINGFUNCTION]

src/sorcha/data/survey_setups/Rubin_full_footprint.ini

@@ -86,12 +86,13 @@ phase_function = HG
 camera_model = footprint
 
 # The distance from the edge of a detector (in arcseconds on the focal plane)
-# at which we will not correctly extract an object.
-# footprint_edge_threshold = 0.0001
+# at which we will not correctly extract an object. By default this is 10px or 2 arcseconds.
+# Comment out or do not include if using footprint camera model.
+footprint_edge_threshold = 2.
 
 # Path to camera footprint file. Uncomment to provide a path to the desired camera 
-# detector configurationn file if not using the default built-in LSSTCam detector 
-# configuration or not using the circle footprint model.
+# detector configuration file if not using the default built-in LSSTCam detector 
+# configuration for the actual camera footprint.
 # footprint_path= ./data/detectors_corners.csv
 
 

src/sorcha/data/survey_setups/Rubin_known_object_prediction.ini

@@ -77,22 +77,14 @@ phase_function = HG
 camera_model = footprint
 
 # Path to camera footprint file. Uncomment to provide a path to the desired camera 
-# detector configurationn file if not using the default built-in LSSTCam detector 
-# configuration or not using the circle footprint model.
+# detector configuration file if not using the default built-in LSSTCam detector 
+# configuration for the actual camera footprint.
 # footprint_path= ./data/detectors_corners.csv
 
-# Fraction of detector surface area which contains CCD -- simulates chip gaps
-# for OIF output. Comment out if using camera footprint.
-# Default: 0.9.
-# fill_factor = 0.9
-
-# Radius of the circle for a circular footprint (in degrees). Float.
-# Comment out or do not include if using footprint camera model.
-# circle_radius = 1.75
-
 # The distance from the edge of a detector (in arcseconds on the focal plane)
-# at which we will not correctly extract an object.
-# footprint_edge_threshold = 0.0001
+# at which we will not correctly extract an object. By default this is 10px or 2 arcseconds.
+# Comment out or do not include if using footprint camera model.
+footprint_edge_threshold = 2.
 
 
 [FADINGFUNCTION]

tests/data/PPConfig_goldens_test.ini

@@ -59,23 +59,15 @@ phase_function = HG
 # Options: circle, footprint.
 camera_model = footprint
 
-# Path to camera footprint file. Uncomment to provide a path to the desired camera 
-# detector configurationn file if not using the default built-in LSSTCam detector 
-# configuration or not using the circle footprint model.
-# footprint_path= ./data/detectors_corners.csv
-
-# Fraction of detector surface area which contains CCD -- simulates chip gaps
-# for OIF output. Comment out if using camera footprint.
-# Default: 0.9.
-# fill_factor = 0.9
-
-# Radius of the circle for a circular footprint (in degrees). Float.
+# The distance from the edge of a detector (in arcseconds on the focal plane)
+# at which we will not correctly extract an object. By default this is 10px or 2 arcseconds.
 # Comment out or do not include if using footprint camera model.
-# circle_radius = 1.75
+footprint_edge_threshold = 2.
 
-# The distance from the edge of a detector (in arcseconds on the focal plane)
-# at which we will not correctly extract an object.
-# footprint_edge_threshold = 0.0001
+# Path to camera footprint file. Uncomment to provide a path to the desired camera 
+# detector configuration file if not using the default built-in LSSTCam detector 
+# configuration for the actual camera footprint.
+# footprint_path= ./data/detectors_corners.csv
 
 
 [FADINGFUNCTION]

tests/data/PPConfig_test_chunked.ini

@@ -59,23 +59,15 @@ phase_function = HG
 # Options: circle, footprint.
 camera_model = footprint
 
-# Path to camera footprint file. Uncomment to provide a path to the desired camera 
-# detector configurationn file if not using the default built-in LSSTCam detector 
-# configuration or not using the circle footprint model.
-# footprint_path= ./data/detectors_corners.csv
-
-# Fraction of detector surface area which contains CCD -- simulates chip gaps
-# for OIF output. Comment out if using camera footprint.
-# Default: 0.9.
-# fill_factor = 0.9
-
-# Radius of the circle for a circular footprint (in degrees). Float.
+# The distance from the edge of a detector (in arcseconds on the focal plane)
+# at which we will not correctly extract an object. By default this is 10px or 2 arcseconds.
 # Comment out or do not include if using footprint camera model.
-# circle_radius = 1.75
+footprint_edge_threshold = 2.
 
-# The distance from the edge of a detector (in arcseconds on the focal plane)
-# at which we will not correctly extract an object.
-# footprint_edge_threshold = 0.0001
+# Path to camera footprint file. Uncomment to provide a path to the desired camera 
+# detector configuration file if not using the default built-in LSSTCam detector 
+# configuration for the actual camera footprint.
+# footprint_path= ./data/detectors_corners.csv
 
 
 [FADINGFUNCTION]

tests/data/PPConfig_test_unchunked.ini

@@ -59,23 +59,15 @@ phase_function = HG
 # Options: circle, footprint.
 camera_model = footprint
 
-# Path to camera footprint file. Uncomment to provide a path to the desired camera 
-# detector configurationn file if not using the default built-in LSSTCam detector 
-# configuration or not using the circle footprint model.
-# footprint_path= ./data/detectors_corners.csv
-
-# Fraction of detector surface area which contains CCD -- simulates chip gaps
-# for OIF output. Comment out if using camera footprint.
-# Default: 0.9.
-# fill_factor = 0.9
-
-# Radius of the circle for a circular footprint (in degrees). Float.
+# The distance from the edge of a detector (in arcseconds on the focal plane)
+# at which we will not correctly extract an object. By default this is 10px or 2 arcseconds.
 # Comment out or do not include if using footprint camera model.
-# circle_radius = 1.75
+footprint_edge_threshold = 2.
 
-# The distance from the edge of a detector (in arcseconds on the focal plane)
-# at which we will not correctly extract an object.
-# footprint_edge_threshold = 0.0001
+# Path to camera footprint file. Uncomment to provide a path to the desired camera 
+# detector configuration file if not using the default built-in LSSTCam detector 
+# configuration for the actual camera footprint.
+# footprint_path= ./data/detectors_corners.csv
 
 
 [FADINGFUNCTION]

tests/data/config_for_ephemeris_unit_test.ini

@@ -83,23 +83,15 @@ phase_function = HG
 # Options: circle, footprint.
 camera_model = footprint
 
-# Path to camera footprint file. Uncomment to provide a path to the desired camera 
-# detector configurationn file if not using the default built-in LSSTCam detector 
-# configuration or not using the circle footprint model.
-# footprint_path= ./data/detectors_corners.csv
-
-# Fraction of detector surface area which contains CCD -- simulates chip gaps
-# for OIF output. Comment out if using camera footprint.
-# Default: 0.9.
-# fill_factor = 0.9
-
-# Radius of the circle for a circular footprint (in degrees). Float.
+# The distance from the edge of a detector (in arcseconds on the focal plane)
+# at which we will not correctly extract an object. By default this is 10px or 2 arcseconds.
 # Comment out or do not include if using footprint camera model.
-# circle_radius = 1.75
+footprint_edge_threshold = 2.
 
-# The distance from the edge of a detector (in arcseconds on the focal plane)
-# at which we will not correctly extract an object.
-# footprint_edge_threshold = 0.0001
+# Path to camera footprint file. Uncomment to provide a path to the desired camera 
+# detector configuration file if not using the default built-in LSSTCam detector 
+# configuration for the actual camera footprint.
+# footprint_path= ./data/detectors_corners.csv
 
 
 [FADINGFUNCTION]