Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix choices having an "options" prefix when automatically localizing #2490

Merged
merged 3 commits into from
Jul 29, 2023

Conversation

freya022
Copy link
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Fixes automatic localization adding "options" before the choice name

@MinnDevelopment
Copy link
Member

What exactly does this change impact? Can this break existing localization files/code?

@freya022
Copy link
Contributor Author

If you made a workaround for this bug then of course it's breaking, but since the docs never mentioned that extra "options" (even in the examples) then that should be fine

@MinnDevelopment MinnDevelopment added beta-blocker Should be merged before dropping beta classification bug type: semi-breaking this might change internals in a non-comptible way labels Jun 30, 2023
@MinnDevelopment MinnDevelopment merged commit c33fb9d into discord-jda:master Jul 29, 2023
1 check passed
@freya022 freya022 deleted the fix/choice-localization branch July 29, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-blocker Should be merged before dropping beta classification bug type: semi-breaking this might change internals in a non-comptible way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants