Chage return type of method in JDA class. #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed the return type of "openPrivateChannelById(String)" from RestAction to CacheRestAction as it delegates to a method that returns CacheRestAction.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
The return type of
JDA#openPrivateChannelById(long)isCacheRestAction. However, the methodJDA#openPrivateChannelById(String)returnsRestAction, implying that the cache will not be used. This seems inconsistent, especially considering that the String method delegates to the long method.Also changed the documentation of
JDA#openPrivateChannelById(String)to clarify that the cache will be used.