-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Collection to its own repository #1291
base: master
Are you sure you want to change the base?
Conversation
Not gonna lie, I don't see how this is beneficial. Just creates more overhead to maintain it separately? |
Several of the existing functions are outdated to be backwards compatible with old PHP versions. By moving it to a new repository we can introduce releases with their own PHP minimum versions and composer will automatically update to the end-user's most compatible up-to-date version without needing to force everybody to use PHP 8.4. |
This actually makes maintaining the classes much easier as we can choose to drop backwards compatibility at any time in the future without needing to worry about rewriting functions at the same time, and it removes the extra effort from end-users as composer.json will handle choosing the appropriate version. Both branches of the new repository will respect the |
I don't think its a good idea to reuse the namespace. Feels like youre just waiting for the autoloader to pull the class from the wrong place to me |
I'm not sure I follow. Why would we want to change the namespace on an existing class within the library? The only difference is we've moved it to its own repository. I don't see how the autoloader would come into play here unless someone using the library explicitly tried to reuse our namespaces, which would be an issue even without this PR. |
No description provided.