[Apps] New accordion groups, autocomplete search to filter by existing set of all users with App permissions #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…part 0 of breaking down the group tables into accordions
savathoon
force-pushed
the
sava/more-components
branch
from
0b8cb5d
to
c440947
Compare
savathoon
changed the title
…to roles for users (#176)
…ent when it's in an accordion element
src/pages/apps/Read.tsx
Outdated
| <AppsAccordionListGroup | ||
| app_group={app.active_owner_app_groups} | ||
| list_group_title={'Owner Group'} | ||
| list_group_description={'Members can manage all app groups as implicit owners'} |
There was a problem hiding this comment.
Suggested change
| list_group_description={'Members can manage all app groups as implicit owners'} | |
| list_group_description={'Owners can manage all app groups as implicit owners'} |
There was a problem hiding this comment.
To be more clear, only members of the special built-in group App-Access-Owners are super-admins in Access. For a normal app in Access, owners of the associated Owners app group are admins for the app and all associated groups.
|
Can you remove the |
Co-authored-by: amyjchen <[email protected]>
savathoon
changed the title
| }}> | ||
| <Stack direction="row" width="100%" justifyContent="space-between"> | ||
| <CreateUpdateGroup defaultGroupType={'app_group'} currentUser={currentUser} app={app} /> | ||
| <Autocomplete |
There was a problem hiding this comment.
Looks like when selecting an option it keeps the entire encoded option data with the semi-colon. I believe there's a way to strip this out after a selection is made. During onChange?
Also I wonder if it feels more like a search box if we add the freeSolo prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: