Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document incident actions #6396

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: document incident actions #6396

wants to merge 2 commits into from
+42 −5

Conversation

Lulalaby
Copy link
Contributor

@Lulalaby Lulalaby commented Sep 1, 2023 •
edited
Loading

Waiting for #7098

@sebm253 sebm253 mentioned this pull request Sep 1, 2023
Draft
2 tasks
DonovanDMC added a commit to OceanicJS/Oceanic that referenced this pull request Sep 3, 2023
@DonovanDMC
incident actions
dc8defc 
discord/discord-api-docs#6396
@seailz seailz mentioned this pull request Sep 3, 2023
Closed
3 tasks
@Lulalaby Lulalaby marked this pull request as ready for review September 12, 2023 23:56
Lulalaby
Lulalaby commented Sep 19, 2023
View reviewed changes
docs/resources/Guild.md Outdated Show resolved Hide resolved
docs/resources/Guild.md Outdated Show resolved Hide resolved
valdotle
valdotle reviewed Sep 19, 2023
View reviewed changes
docs/resources/Guild.md Show resolved Hide resolved
docs/resources/Guild.md Outdated Show resolved Hide resolved
docs/resources/Guild.md Outdated Show resolved Hide resolved
docs/resources/Guild.md Show resolved Hide resolved
@sdanialraza sdanialraza mentioned this pull request Sep 19, 2023
Draft
@Misha-133 Misha-133 mentioned this pull request Sep 29, 2023
Merged
@Soheab Soheab mentioned this pull request Sep 30, 2023
Merged
6 tasks
@Soheab
Copy link

Soheab commented Oct 1, 2023 •
edited
Loading

Does this fire any gateway event like GUILD_UPDATE when the actions change at any time? Doesn't seem like it.

@Soheab
Copy link

Soheab commented Oct 3, 2023 •
edited
Loading

Passing null to any of the fields disables all actions, is this intended?

Edit: when only one field is being set.

@Lulalaby
Copy link
Contributor Author

Lulalaby commented Oct 3, 2023

It wasn't the previous behavior at least

@jaw0r3k jaw0r3k mentioned this pull request Oct 29, 2023
Closed
@MinnDevelopment MinnDevelopment mentioned this pull request Oct 29, 2023
Open
6 tasks
@seailz
Copy link
Contributor

seailz commented Dec 1, 2023

any update on this one?

@sdanialraza
Copy link
Contributor

There also seems to be dm_spam_detected_at and raid_detected_at fields, could you please document those as well?

@MCausc78 MCausc78 mentioned this pull request Jan 19, 2024
Merged
@bsian03 bsian03 mentioned this pull request Feb 27, 2024
Open
54 tasks
@Lulalaby Lulalaby closed this Apr 25, 2024
@Lulalaby Lulalaby deleted the incident-actions branch April 25, 2024 10:47
@Lulalaby Lulalaby restored the incident-actions branch April 25, 2024 10:48
@Lulalaby Lulalaby reopened this Apr 25, 2024
@Lulalaby
Copy link
Contributor Author

@sdanialraza i added the fields to the documentation as well

@Lulalaby Lulalaby changed the title Document incident actions docs: document incident actions Apr 25, 2024
@JustinBeckwith JustinBeckwith self-requested a review May 27, 2024 02:23
@JustinBeckwith
Copy link
Contributor

Note for future me - this is currently flagged as private in our Open API spec, and I need to go figure out why.

@Lulalaby
Copy link
Contributor Author

yeah heard that. surprises me

@Jiralite Jiralite mentioned this pull request Jul 1, 2024
Merged
@shiftinv shiftinv mentioned this pull request Aug 17, 2024
Open
8 tasks
@Lulalaby Lulalaby requested a review from a team as a code owner August 24, 2024 03:10
@Lulalaby
Copy link
Contributor Author

Lulalaby commented Aug 24, 2024 •
edited
Loading

I'll have to redo the pr if #7098 is merged, something messed up

valdotle
valdotle reviewed Sep 22, 2024
View reviewed changes
docs/resources/Guild.md
Comment on lines +668 to +673
```json
{
"invites_disabled_until": "2023-09-01T14:48:02.222000+00:00",
"dms_disabled_until": null
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either the example is incomplete or dm_spam_detected_at and raid_detected_at should be marked as optional in the above table.

docs/resources/Guild.md
###### JSON Params

> info
> Both `invites_disabled_until` and `dms_disabled_until` can be disabled for a maximal timespan of 24 hours in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Both `invites_disabled_until` and `dms_disabled_until` can be disabled for a maximal timespan of 24 hours in the future.
> Both `invites_disabled_until` and `dms_disabled_until` can be enabled for a maximal timespan of 24 hours in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanctech nathanctech nathanctech left review comments

@valdotle valdotle valdotle left review comments

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Lulalaby @Soheab @seailz @sdanialraza @JustinBeckwith @nathanctech @valdotle