-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some simple changes #261
Some simple changes #261
Conversation
Update docker files, upgrade to djs v14, and node v18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEL relies extensively on client.api
which was replaced by client.rest
in d.js v14, so I don't see how it's possible that this code works?
You are correct, it seems my docker build had not updated (I guess I forgot to prune it) and it does in fact, not operate on v14 as expected. I'll make the corrected changes tonight! Though it would sure help if discord.js documented the new discord.js/rest system, since it's entirely empty :^) |
Actually change things to work with discord.js v14
Added correct changes for discord.js v14! All of these have actually been tested correctly this time (lol) - my bad about earlier. The changes should be broken down easily with the commit messages, and side-by-side comparisons! |
Use proper enums
Is this on pause or is it safe to merge this and work on the remaining patches at a later date? Also, what else needs to be done? Would like to work on some stuff myself if possible so I'm at least somewhat productive in my spare time 😅 |
Last I checked these fixes worked, though I had a server raid card go bad not too long ago and it screwed up the VM I had setup for testing this (didn't have a backup for it), so I can't 100% verify it works with the latest API changes. From what I can see though it should work fine! |
@@ -94,7 +94,6 @@ | |||
|
|||
const input = document.querySelector("input.input.is-rounded.is-dark#searchInput"); | |||
|
|||
if (input.value.match(/gay(\s+)?(men\s+)?.*/i)) return window.location.href = "/users/302604426781261824"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmfao I forgot this code still existed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a reasonable amount of testing, changes in the pull request itself work fine. Functions okay!
Some simple changes, mostly in prep for some other fixes/additions discussed in the community discord
These changes have been tested and work properly on Ubuntu 22.04.2 LTS