Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some simple changes #261

Merged
merged 38 commits into from
Feb 25, 2024
Merged

Conversation

TheAlienKnight
Copy link
Contributor

Some simple changes, mostly in prep for some other fixes/additions discussed in the community discord

  • Changes docker files, allowing for a less confusing setup process
  • Bumps node to v18 since v17 is EOL
  • Bumps Discord.js to v14, since v13 is soon to be obsolete
  • Changes a few small things to allow discord.js v14 to work properly

These changes have been tested and work properly on Ubuntu 22.04.2 LTS

Copy link
Member

@advaith1 advaith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEL relies extensively on client.api which was replaced by client.rest in d.js v14, so I don't see how it's possible that this code works?

.docker-compose.yml Outdated Show resolved Hide resolved
src/Util/Services/discord.ts Outdated Show resolved Hide resolved
@TheAlienKnight
Copy link
Contributor Author

You are correct, it seems my docker build had not updated (I guess I forgot to prune it) and it does in fact, not operate on v14 as expected. I'll make the corrected changes tonight! Though it would sure help if discord.js documented the new discord.js/rest system, since it's entirely empty :^)

@TheAlienKnight
Copy link
Contributor Author

Added correct changes for discord.js v14! All of these have actually been tested correctly this time (lol) - my bad about earlier. The changes should be broken down easily with the commit messages, and side-by-side comparisons!

@advaith1 advaith1 self-requested a review March 21, 2023 03:01
@carolinaisslaying
Copy link
Member

Is this on pause or is it safe to merge this and work on the remaining patches at a later date? Also, what else needs to be done? Would like to work on some stuff myself if possible so I'm at least somewhat productive in my spare time 😅

@TheAlienKnight
Copy link
Contributor Author

Last I checked these fixes worked, though I had a server raid card go bad not too long ago and it screwed up the VM I had setup for testing this (didn't have a backup for it), so I can't 100% verify it works with the latest API changes. From what I can see though it should work fine!

@@ -94,7 +94,6 @@

const input = document.querySelector("input.input.is-rounded.is-dark#searchInput");

if (input.value.match(/gay(\s+)?(men\s+)?.*/i)) return window.location.href = "/users/302604426781261824";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmfao I forgot this code still existed

@carolinaisslaying carolinaisslaying modified the milestones: 6.0.0, 5.6.0 Feb 25, 2024
Copy link
Member

@carolinaisslaying carolinaisslaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a reasonable amount of testing, changes in the pull request itself work fine. Functions okay!

@carolinaisslaying carolinaisslaying merged commit 4abf5d2 into discordextremelist:main Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moderate priority Issue/PR is moderate priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants