Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge #8229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Purge #8229

wants to merge 3 commits into from

Conversation

vode-code
Copy link
Contributor

@vode-code vode-code commented Jul 11, 2023

About The Pull Request

This PR removes the old Syndicate Mobs, the Blob Event, the Shock Pack and Electric Chair, and a variety of unused code.

Why It's Good For The Game

the less old code there is, the less tech debt there is.

Testing

launched properly, joined game, saw no abnormalities, walked around, saw no abnormalities

Changelog

🆑
del: Removed Blob Event
del: Removed Electropack
del: Removed Manhack Grenades and Viscerators
code: removed a variety of unused files
/:cl:

removes Blob Event
removes Viscerators
removes electropacks
removes "Send Emergency Message" verb
removes some unused files
removes outdated portrayal of Syndicate mobs
@MLGTASTICa
Copy link
Contributor

I love removing code and then refusing to add any other features to fill in the feature void ,especially when said features are not extremly prone to bugs and have proven to work fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two blank lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, would rather not do a commit purely for a single newline though.

@ValoTheValo
Copy link
Contributor

Dont remove the blob. shock pack and electric chair aren't even used but why remove blob?

@Firefox13
Copy link
Contributor

No, compiled successfully isn't proper testing.

@vode-code
Copy link
Contributor Author

No, compiled successfully isn't proper testing.

joining a server without a ckey is completely disabled by #8096 due to bad index ckey runtime.

@Iglpigl
Copy link
Contributor

Iglpigl commented Jul 11, 2023

Join while logged in then.

@assortedbeads
Copy link
Contributor

People use manhacks and vivisectors what the hell are you on about

Copy link
Contributor

@Firefox13 Firefox13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove manhack grenades.
Some of these changes are controversial so a little more explaining on why it's good would be appreciated.

@MLGTASTICa
Copy link
Contributor

No, compiled successfully isn't proper testing.

joining a server without a ckey is completely disabled by #8096 due to bad index ckey runtime.

its not due to a runtime its litteraly a server config change by default to not allow guest keys. Just change the config.

@Firefox13
Copy link
Contributor

Cam also be changed live in server tab

@vode-code
Copy link
Contributor Author

joining a server without a ckey is completely disabled by #8096 due to bad index ckey runtime.

its not due to a runtime its litteraly a server config change by default to not allow guest keys. Just change the config.

while guest keys may not runtime, lacking any key at all does runtime, and can be done by running the game server without running a BYOND client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants