Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RIG suit, apron, xeno suit, and fire suit sprites #8515

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

XElectricX
Copy link
Contributor

@XElectricX XElectricX commented Aug 13, 2024

About The Pull Request

Redo of #8410 with conflicts resolved and fixes made.

Why It's Good For The Game

Pretty sprites.

Testing

Tested each RIG, sealed and unsealed.

Changelog

🆑
imageadd: New RIG suit, apron, xeno suit, and fire suit sprites.
/:cl:

@SirRichardFrancis
Copy link
Member

>Sprite update PR
>No pictures
image

@SirRichardFrancis
Copy link
Member

image

image

image

image

Engineering RIG's boots are off one pixel to the left. You're welcome.

@SirRichardFrancis
Copy link
Member

Oh, and this too. Look at the apron.

image

Btw, why the hell does sprite replacement PR come with balance changes?

@Firefox13
Copy link
Contributor

изображение
The above screenshots provided by KIROV (thank you KIROV) show the importance of testing everything
And yeah, put the balance changes into a different PR please.

@githubuser4141
Copy link
Contributor

githubuser4141 commented Aug 14, 2024

Oh, and this too. Look at the apron.

image

Btw, why the hell does sprite replacement PR come with balance changes?

It's not balance, it just adds armor values to the xeno armor, because well, it's fucking xeno armor - it's supposed to be at least a little durable.
image
Deco-level of armor that just might stop someone punching you.

@TheLeopold
Copy link
Contributor

it just adds armor values

that's exactly what balance change is

@SirRichardFrancis
Copy link
Member

SirRichardFrancis commented Aug 14, 2024

it just adds armor values to the xeno armor

It's not an armor though? Just a cosplay costume, these are not meant to be armored I believe.
But regardless, anything to do with numbers going up or down does not belong with fixes, QoL, or sprite changes.

Copy link
Contributor

@Humonitarian Humonitarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep balance changes as a separate PR.

@XElectricX XElectricX marked this pull request as draft August 18, 2024 03:21
@XElectricX XElectricX changed the title New RIG suit, apron, xeno suit (+armor buff), and fire suit sprites New RIG suit, apron, xeno suit, and fire suit sprites Aug 20, 2024
@XElectricX XElectricX marked this pull request as ready for review August 20, 2024 23:30
@githubuser4141
Copy link
Contributor

The armour changes are gone I think

Copy link
Member

@SirRichardFrancis SirRichardFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boots are fixed, but apron still appears to be somewhat misaligned.

image

@XElectricX
Copy link
Contributor Author

Boots are fixed, but apron still appears to be somewhat misaligned.

image

Is this the female or male one?

@SirRichardFrancis
Copy link
Member

Both.

@Humonitarian
Copy link
Contributor

You're good with sprites @SirRichardFrancis , can you approve this once there's no more sprite issues? I'll take that as sign its all good now

@SirRichardFrancis
Copy link
Member

@SirRichardFrancis , can you approve this once there's no more sprite issues? I'll take that as sign its all good now

Yeah, I will approve once it's good. Currently waiting on PR author to do something about the apron sprites.

@github-actions github-actions bot added the Merge Conflict Merge Conflict label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants