Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(command-deployment): Cleanup page #1525

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(command-deployment): Cleanup page #1525

merged 1 commit into from
Nov 28, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 21, 2023 •
edited
Loading

Following the guide from the beginning, there are some changes that need to be made to this page.

  • Important comment difference between guide and code sample regarding folders vs. files.
  • Removed "bonus commands". They should be introduced if they are actually introduced in the guide.
  • Code samples were not 1:1 with the implementation in prior sections. This may cause confusion.

@almostSouji almostSouji mentioned this pull request Nov 23, 2023
Merged
@Jiralite Jiralite mentioned this pull request Nov 25, 2023
Merged
@Jiralite Jiralite force-pushed the fix/command-deployment-cleanup branch from 1f1f5bc to 6648019 Compare November 28, 2023 11:27
@Jiralite Jiralite merged commit 400d0db into main Nov 28, 2023
6 checks passed
@Jiralite Jiralite deleted the fix/command-deployment-cleanup branch November 28, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monbrey monbrey monbrey left review comments

@almostSouji almostSouji almostSouji approved these changes

Assignees
No one assigned
Labels
type: bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiralite @monbrey @almostSouji