-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow multiple occurencies of builder statements #50
Conversation
reopen #42 because of loosing code in master branch |
now mini-sql behaves incorrectly MINI_SQL.build('(/*select*/ from orders) union (/*select*/ from line_items)').select('user_id').query
(SELECT user_id from orders) union (/*select*/ from line_items) this PR fix it (SELECT user_id from orders) union (SELECT user_id from line_items) |
I support this, but it is technically a breaking change, going to have to bump versions for it. |
I wonder if we need a new param to explicitly opt for polymorphic. |
@SamSaffron hello, I come across this problem from time to time in my work also not work with builder = MINI_SQL.build(<<~SQL)
SELECT
DISTINCT ON (/*snap_grid*/)
coords
FROM delivery_offices
ORDER BY /*snap_grid*/
SQL
builder.sql_literal(snap_grid: 'ST_SnapToGrid(coords, 0.0007, 0.00035)') can you merge this PR and bump new gem version? |
Yes I am fine with this, but I would like an example added to the README as well here. It feels like a feature we should document. Also, technically this is a breaking change, we are going to need a full version bump for it, go ahead and do so and also explain in the changelog. |
069e835
to
5dc5a72
Compare
Hello, @SamSaffron. It's done. Do you bump version and add comment to changelog by yourself? |
I am merging it in, will discuss internally if it makes sense to do a full major version bump for this. Really depends how you squint, this is either a breaking change or bug fix... |
No description provided.