[prepared statements] fix for auto_encode_arrays, refactoring #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermolaev
force-pushed
the
fix-empty-array
branch
3 times, most recently
from
201d373
to
c36178c
Compare
ermolaev
force-pushed
the
fix-empty-array
branch
2 times, most recently
from
49dc09b
to
06775fe
Compare
ermolaev
force-pushed
the
fix-empty-array
branch
from
06775fe
to
36635d7
Compare
ermolaev
changed the title
ermolaev
commented
Aug 22, 2024
| when true then "true" | ||
| when false then "false" | ||
| when nil then "NULL" | ||
| when EMPTY_ARRAY then array_encoder ? "'{}'" : "NULL" |
There was a problem hiding this comment.
arr = []
freeze_arr = [].freeze
Benchmark.ips do |x|
x.report("new") {
case arr
when [] then true
else false
end
}
x.report("inline freeze") {
case arr
when [].freeze then true
else false
end
}
x.report("var freeze") {
case arr
when freeze_arr then true
else false
end
}
x.compare!
end;
# Comparison:
# var freeze: 6412829.6 i/s
# new: 5822569.7 i/s - 1.10x slower
# inline freeze: 5379263.0 i/s - 1.19x slower
ermolaev
commented
Aug 22, 2024
| @@ -30,8 +26,9 @@ def deserializer_cache | |||
|
|
|||
| private def run(sql, params) | |||
| prepared_sql, binds, _bind_names = @param_binder.bind(sql, *params) | |||
| @prepared_cache ||= PreparedCache.new(unprepared) | |||
ermolaev
commented
Aug 22, 2024
| @@ -28,6 +28,10 @@ def prepare_statement(sql) | |||
|
|
|||
| private | |||
|
|
|||
| def raw_connection | |||
| @connection.raw_connection | |||
There was a problem hiding this comment.
for usage with ActiveRecord
|
@SamSaffron PR ready to review |
ermolaev
force-pushed
the
fix-empty-array
branch
from
6b2f1d4
to
bc2598c
Compare
ermolaev
force-pushed
the
fix-empty-array
branch
from
bc2598c
to
35e3eb6
Compare
ermolaev
commented
Aug 22, 2024
Comment on lines
+25
to
+42
| class MiniSql::Postgres::TestAutoEncodeArraysPrepared < MiniSql::Postgres::TestPreparedConnection | ||
| include MiniSql::Postgres::ArrayTests | ||
|
|
||
| def setup | ||
| @unprepared_connection = pg_connection(auto_encode_arrays: true) | ||
| @connection = @unprepared_connection.prepared | ||
|
|
||
| setup_tables | ||
| end | ||
| end | ||
|
|
||
| class MiniSql::Postgres::TestAutoEncodeArraysUnprepared < MiniSql::Postgres::TestConnection | ||
| include MiniSql::Postgres::ArrayTests | ||
|
|
||
| def setup | ||
| @connection = pg_connection(auto_encode_arrays: true) | ||
| end | ||
| end |
There was a problem hiding this comment.
run all test for connection with auto_encode_arrays: true
ermolaev
commented
Aug 22, 2024
| @@ -61,12 +61,8 @@ def type_map | |||
| @type_map ||= self.class.type_map(raw_connection) | |||
| end | |||
|
|
|||
| def prepared(condition = true) | |||
There was a problem hiding this comment.
in a real application the parameter condition was never used
|
Hi @SamSaffron, I remind you about this PR, because the master branch does not work correctly in some situations in mode |
SamSaffron
approved these changes
Sep 4, 2024
|
no worries, thanks the ruby-head failure is a bit of a nightmare, bigdecimal is a dependency on Ruby 3.4 and up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto_encode_arrays(prepared, unprepared)preparedmethod)ActiveRecord