-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up serialization layer #154
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up the serialization layer.
A goal of this work was to patch our graph traversal code so that we could improve error messages when something goes wrong. Unfortunately this proved to be difficult because we had 5 (!) different places where we were traversing the graph of values/pointers. I'll address the error messages in a follow-up PR and instead focus on tidying up the code as a prerequisite. We're now using the visitor pattern so that we only have one implementation of the graph traversal. I've fixed a handful of bugs while consolidating this code.
Another goal was to reduce our usage of
unsafe
(pointer casting / arithmetic / dereferencing) as much as possible, and instead lean on Go reflection to do the heavy lifting. I moved all generic reflection code into a newinternal/reflectext
(reflection extension) package, to make the serialization layer clearer. There are still places where we need to step outside the safety of the reflection API, but I've consolidated this all intointernal/reflectext/unsafe.go
and documented why.