implement serializable closures #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achille Roussel <[email protected]>
Signed-off-by: Achille Roussel <[email protected]>
Signed-off-by: Achille Roussel <[email protected]>
chriso
approved these changes
Sep 19, 2023
Comment on lines
+119
to
+120
| // TODO: can we figure out a way to know when we are unwinding the | ||
| // stack and only recover then so we don't alter the panic stack? |
There was a problem hiding this comment.
Get the context from gls and then check the resume flag?
There was a problem hiding this comment.
We have the context at this stage in c.ctx 👍
There was a problem hiding this comment.
It doesn't work entirely, when the coroutine is stopped we don't set resume=true; let's look into it in a different PR
Signed-off-by: Achille Roussel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for serializing closures.