Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python Docker tag to v3.13 #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 8, 2024

This PR contains the following updates:

Package Type Update Change
python final minor 3.11 -> 3.13

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from webbnh as a code owner October 8, 2024 00:16
@webbnh
Copy link
Member

webbnh commented Oct 8, 2024

I suspect that the unit tests are failing due to a bottle update.

@dbutenhof
Copy link
Member

I suspect that the unit tests are failing due to a bottle update.

Is the failure coincidental because of an update in bottle, or is this directly related to the Python 3.13 update? (Which seems ... aggressive, since we're mostly still using 3.10 or even 3.9 ... but maybe not.)

@webbnh
Copy link
Member

webbnh commented Oct 8, 2024

The bot thinks that we should be using the "current" version of Python for our base image (hence this PR). Opening the PR triggered a CI run which installed a fresh version of the dependencies, which includes the "current" version of bottle, which, apparently, has the same incompatibility as Pbench faced. And, so, the unit tests failed.

I don't think this has anything to do with Python 3.13. I think it's all about bottle and how we use it. Since we're not rev-locking our dependency on bottle, I guess there was no need for the bot to propose an update to it, so we didn't notice the problem until a different update came by and prompted us to rebuild.

At this time, I'm not particularly excited about updating Python. We probably should make a change here to address the bottle problem, one way or another, though. But, I'm not feeling particularly motivated to do that, right now, either. So, I made my comment above as a note to a future reader (who might well be me...), and I figured I would leave the PR open until we feel like dealing with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants