Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: update actions, and update to go1.21, go1.22 #16

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

thaJeztah
Copy link
Member

  • gha: update actions/checkout@v4
  • gha: update actions/setup-go@v5
  • gha: update golangci/golangci-lint-action@v6
  • gha: update codecov/codecov-action@v4
  • gha: update golangci-lint to v1.59
  • gha: update to go1.21.x, go1.22.x

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah self-assigned this Jul 15, 2024
    Error: fuzz_test.go:11:14: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
        f.Fuzz(func(t *testing.T, data string) {
                    ^

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (ff14faf) to head (343e590).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   83.71%   84.21%   +0.49%     
==========================================
  Files           5        5              
  Lines         393      304      -89     
==========================================
- Hits          329      256      -73     
+ Misses         54       38      -16     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thaJeztah thaJeztah changed the title aha: update actions, and update to go1.21, go1.22 gha: update actions, and update to go1.21, go1.22 Jul 15, 2024
Copy link
Collaborator

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milosgajdos
Copy link
Member

@thaJeztah do you want to squash?

@thaJeztah
Copy link
Member Author

It's probably fine to keep them separate; each of them is for a specific dependency, so they don't really depend on each other.

@thaJeztah
Copy link
Member Author

(if that's good to you that is)

@milosgajdos milosgajdos merged commit 8c942b0 into distribution:main Jul 18, 2024
12 checks passed
@thaJeztah thaJeztah deleted the update_gha branch July 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants