-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: update actions, and update to go1.21, go1.22 #16
Conversation
thaJeztah
commented
Jul 15, 2024
- gha: update actions/checkout@v4
- gha: update actions/setup-go@v5
- gha: update golangci/golangci-lint-action@v6
- gha: update codecov/codecov-action@v4
- gha: update golangci-lint to v1.59
- gha: update to go1.21.x, go1.22.x
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Error: fuzz_test.go:11:14: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive) f.Fuzz(func(t *testing.T, data string) { ^ Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 83.71% 84.21% +0.49%
==========================================
Files 5 5
Lines 393 304 -89
==========================================
- Hits 329 256 -73
+ Misses 54 38 -16
Partials 10 10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@thaJeztah do you want to squash? |
It's probably fine to keep them separate; each of them is for a specific dependency, so they don't really depend on each other. |
(if that's good to you that is) |