Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: remove unused settings, sort linters, and enable dupwords #2

Merged
merged 2 commits into from
Aug 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,27 +1,18 @@
linters:
enable:
- staticcheck
- unconvert
- bodyclose
- dupword # Checks for duplicate words in the source code
milosgajdos marked this conversation as resolved.
Show resolved Hide resolved
- gofmt
- goimports
- revive
- ineffassign
- vet
- unused
- misspell
- bodyclose
- revive
- staticcheck
- unconvert
- unused
- vet
disable:
- errcheck

linters-settings:
revive:
rules:
# TODO(thaJeztah): temporarily disabled the "unused-parameter" check.
# It produces many warnings, and some of those may need to be looked at.
- name: unused-parameter
disabled: true

run:
deadline: 2m
skip-dirs:
- vendor
2 changes: 1 addition & 1 deletion normalize.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func splitDockerDomain(name string) (domain, remainder string) {
}

// familiarizeName returns a shortened version of the name familiar
// to to the Docker UI. Familiar names have the default domain
// to the Docker UI. Familiar names have the default domain
// "docker.io" and "library/" repository prefix removed.
// For example, "docker.io/library/redis" will have the familiar
// name "redis" and "docker.io/dmcgowan/myapp" will be "dmcgowan/myapp".
Expand Down
Loading