Add code coverage to CI #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Aug 31, 2023
thaJeztah
reviewed
Aug 31, 2023
thaJeztah
reviewed
Aug 31, 2023
|
Actually starting to wonder if we should combine workflows, so that we're not doing a git-clone for each (I see GitHub actions is already throttling (waiting for runners), which could be reduced if we run the steps after each-other (single "checkout", then run build, test, coverage) |
|
Yes, we should probably do that. Will give it a go now. |
Jamstah
force-pushed
the
coverage
branch
2 times, most recently
from
b5fcb1b
to
fc87e43
Compare
milosgajdos
approved these changes
Aug 31, 2023
thaJeztah
reviewed
Aug 31, 2023
Jamstah
force-pushed
the
coverage
branch
4 times, most recently
from
a64231d
to
a65c481
Compare
thaJeztah
reviewed
Aug 31, 2023
|
Last version looks good to me; should we merge the commits? The first commit is now adding a file which is immediately removed the commit after; I think for this case, it makes it still clear what's happening if we we combined the two; WDYT? |
|
(either that, or flip the commits, but I expect that would be "possibly hairy" to do) |
Signed-off-by: James Hewitt <[email protected]>
|
Squashed. |
|
@milosgajdos ready to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.