Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spaces between publisher elements #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jason-fox
Copy link
Member

Description

Dublin Core rendering concatenates Organization and PrintLocation incorrectly if both elements are present. This PR adds a space between each element before normalizing whitespace.

Motivation and Context

Consider the following <Bookmap>

 <publisherinformation>
      <organization>Example Publishers</organization>
      <printlocation>Austin, TX</printlocation>
      <published>
        <publishtype value="general"/>
        <completed><year>1977</year></completed>
      </published>
    </publisherinformation>

This currently renders as:

<meta name="DC.publisher" content="Example PublishersAustin, TX1977">

It should render with a space between each element as:

<meta name="DC.publisher" content="Example Publishers Austin, TX 1977">

How Has This Been Tested?

Manual testing

Type of Changes

  • Bug fix

Documentation and Compatibility

  • What documentation changes are needed for this feature?
    (Provide links to existing documentation topics that will require updates)
  • Will this change affect backwards compatibility or other users' overrides?

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant