Add clean_channel method #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my other comment I just made: django/channels#1948 (comment) I do have permissions in this repo, so I ran the workflows for you. My only comment is to update or delete this comment. |
|
@acu192 thank you for taking a look! |
|
hey @fosterseth! can you rebase this PR to test it? I'm having memory leaks in my project and maybe this is it! |
bigfootjon
force-pushed
the
clean_channels
branch
from
ab40db7
to
21e092a
Compare
|
@cacosandon I've rebased the PR for the author, please test at your convenience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires this django PR django/channels#1948
addresses memory leak issue #276