Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Django india linkedIn page with Learn More button #140

Closed
wants to merge 1 commit into from

Conversation

vishwajeetthakur
Copy link

Closes #136

This PR links the Django India LinkedIn page to the "Learn More" button to provide more information about the community.

Changes

  • Linked the "Learn More" button to the official Django India LinkedIn page.
  • Updated the frontend logic to handle the external link opening in a new tab.

Type of change

  • Bug fix

Flags

  • Ensure proper handling of external links across different browsers.
  • Verify if other sections also need external links for consistency.

Demo

  • Clicking the "Learn More" button redirects to the Django India LinkedIn page in a new tab.

How has this been tested?

  • Verified that the button opens the LinkedIn page on click.
  • Tested across different browsers to ensure proper redirection.

Author Checklist

  • Code has been commented, particularly in hard-to-understand areas
  • Changes generate no new warnings
  • Merging to main from fork:main

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Django India! 🎉🇮🇳

We're so happy to see you contribute. Your efforts mean a lot to us and we're excited to have you on this journey.

Before we proceed, please take a moment to review our contribution guide. It's packed with all the information you need to make your contribution seamless.

If you're fixing an issue from the Django India issue tracker, remember to get it assigned to you before you acutally start working on it.

If you ever need help or just want to chat, the Django India discord server is always open. We're here for you!

And while you're here, don't forget to ⭐ star our repo to show your support! It helps the community grow.

Thank you for being a part of Django India. Together, let's make an amazing community! 🚀

Copy link
Collaborator

@engagepy engagepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take to prod

@vishwajeetthakur
Copy link
Author

The PR is ready to be merged. The feature works as expected, and no further issues were found during testing. Merging now to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Learn More is not working
3 participants