-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production deployment #291
Conversation
* add template for NPM BIN PATH for tailwindcss support * add template for NPM BIN PATH for tailwindcss support * local settings for tailwindcss
* add template for NPM BIN PATH for tailwindcss support * add template for NPM BIN PATH for tailwindcss support * local settings for tailwindcss * update contact info on README * update package.json for oryx build
* add template for NPM BIN PATH for tailwindcss support * add template for NPM BIN PATH for tailwindcss support * local settings for tailwindcss * update contact info on README * update package.json for oryx build * error with comment
* add template for NPM BIN PATH for tailwindcss support * add template for NPM BIN PATH for tailwindcss support * local settings for tailwindcss * update contact info on README * update package.json for oryx build * error with comment
* upgrade app service build version and node version in gh actions workflows
* add template for NPM BIN PATH for tailwindcss support * add template for NPM BIN PATH for tailwindcss support * local settings for tailwindcss * update contact info on README * update package.json for oryx build * error with comment * upgrade app service build version and node version in gh actions workflows * python version 3.11
This reverts commit e847975.
Sentry should be helping with this, but I'm still running into application errors that don't make their way to Sentry.
This would require us to have the database connection settings in our github repository and that doesn't sit well with me currently. Let's keep looking.
Supervisor would allow us to programatically run background tasks more easily.
Oryx's post build command won't install the dependencies within the image. The next place I know we can install them is from within the startup command.
It was failing to start up causing the whole server to not load.
Installing things via the startup command causing conflicts from the apt lockfile.
* Add factory_boy dependency. * Add factories for tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any major issues with what's here. Thanks for pushing this along!
</tr> | ||
</table> | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing EOL. Don't forget to install precommit if you haven't already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pre-commit causes me issues as it's setup for python 3.11, this is all for python 3.9 and normally I use 3.12 😅
I think I would prefer the listing in the ci and I would fix anything that comes up and I think we want black too.
Anyways, added the EOL in the followup PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the listing in the ci
What do you mean by "listing" here?
I would fix anything that comes up and I think we want black too
Since our repo is public, I think pre-commit ci can auto-apply fixes to PRs if we configure it to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo/autocorrect sorry "listing" = "linting"
This draft PR is to receive the reviews I have 'skipped' ❤️
Review comments should be addressed here: #292
Main updates
New field
receive_program_updates
added to theProfile
modelThis field will be used in future when determining who to send notification emails to about new sessions.
As a migration has been added, we should watch that migrations were applied during the deployment.
Sentry setup and logging config updates
These are to better investigate errors. Sentry account details are in bitwarden.
Removal of our Google interest form
This is now replaced by the signup process.
Plan to send an email to all those who filled in the interest form to create an account in djangonaut.space in order to receive email updates going forward.
HTML template for our emails
Fixed and basic restyling to our account pages
On production, our account pages mostly lead to Internal sever errors e.g. https://djangonaut.space/accounts/signup/
This is because they were missing some installed packages. However, the styling didn't match our current site so I have also tried to adjust them a bit.
Registration
Profile
Login
Reset password
etc
Other updates included