Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intel CET to getTargetInfo #15433

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Add Intel CET to getTargetInfo #15433

merged 1 commit into from
Aug 27, 2023

Conversation

ErnyTech
Copy link

This follows PR #15415 which added Intel CET IBT support and LDC PR #4437 to add support for the new CET target in order to maintain a common interface between DMD and LDC.

Later it would be useful to do the same for GDC as well.

@ErnyTech ErnyTech requested a review from ibuclaw as a code owner July 19, 2023 16:30
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ErnyTech! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15433"

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use "intelCET" instead of just "CET" as the later is not very well known.

@dkorpel
Copy link
Contributor

dkorpel commented Jul 19, 2023

Why does D code need to know about this setting?

@ghost
Copy link

ghost commented Jul 19, 2023

Why does D code need to know about this setting?

inline asm maybe ?

@ErnyTech
Copy link
Author

ErnyTech commented Jul 19, 2023

Why does D code need to know about this setting?

Mainly for inline ASM.

I suggest to use "intelCET" instead of just "CET" as the later is not very well known.

C compilers use __CET__, I think CET is clear enough for those who have already used Intel CET

Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry describing this change so that users get to know about this.

@ErnyTech
Copy link
Author

Please add a changelog entry describing this change so that users get to know about this.

Added

changelog/dmd.intel-cet-ibt-protection.dd Outdated Show resolved Hide resolved
This follows PR dlang#15415 which added Intel CET IBT support and
LDC PR dlang#4437 to add support for the new CET target in order
to maintain a common interface between DMD and LDC.

Later it would be useful to do the same for GDC as well.
@WalterBright WalterBright dismissed their stale review July 28, 2023 16:26

satisfactory explanation

@ErnyTech
Copy link
Author

@dkorpel Is there anything blocking this PR? I think it would be good to include it in 2.106.0-beta especially since it also provides the changelog for -fIBT
Walter's request seems satisfied

@dkorpel dkorpel merged commit a2695d8 into dlang:master Aug 27, 2023
40 checks passed
@ibuclaw
Copy link
Member

ibuclaw commented Oct 14, 2023

This test is non-portable, and impossible to downstream into gdc (and I assume ldc must be the same as well). Maybe there should be an x86 directory added for such tests - this would include all DMD asm tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants