-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intel CET to getTargetInfo #15433
Conversation
Thanks for your pull request and interest in making D better, @ErnyTech! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15433" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to use "intelCET" instead of just "CET" as the later is not very well known.
Why does D code need to know about this setting? |
inline asm maybe ? |
Mainly for inline ASM.
C compilers use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry describing this change so that users get to know about this.
Added |
This follows PR dlang#15415 which added Intel CET IBT support and LDC PR dlang#4437 to add support for the new CET target in order to maintain a common interface between DMD and LDC. Later it would be useful to do the same for GDC as well.
@dkorpel Is there anything blocking this PR? I think it would be good to include it in 2.106.0-beta especially since it also provides the changelog for -fIBT |
This test is non-portable, and impossible to downstream into gdc (and I assume ldc must be the same as well). Maybe there should be an x86 directory added for such tests - this would include all DMD |
This follows PR #15415 which added Intel CET IBT support and LDC PR #4437 to add support for the new CET target in order to maintain a common interface between DMD and LDC.
Later it would be useful to do the same for GDC as well.