-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows BCrypt bindings #20740
base: master
Are you sure you want to change the base?
Add Windows BCrypt bindings #20740
Conversation
Thanks for your pull request and interest in making D better, @ichordev! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20740" |
Removed trailing whitespace. |
Would be nice to add a changelog entry for this |
Will do! |
I tried to generate the preview but it didn't work, so hopefully I did it correctly! Thought I'd have to write my name somewhere? |
OK this time I actually staged the whole changelog and not half of it. 🤦♀️ |
Adds Windows BCrypt bindings (
core.sys.windows.bcrypt
) to help make this Phobos PR more awesome, and to allow people in general to move away from using the deprecated Windows CryptoAPI.sdkddkver
andw32api
are updated here also becausebcrypt
has conditional compilation that relies on more up-to-date versions of those headers.