Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows BCrypt bindings #20740

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Windows BCrypt bindings #20740

wants to merge 2 commits into from

Conversation

ichordev
Copy link

Adds Windows BCrypt bindings (core.sys.windows.bcrypt) to help make this Phobos PR more awesome, and to allow people in general to move away from using the deprecated Windows CryptoAPI.
sdkddkver and w32api are updated here also because bcrypt has conditional compilation that relies on more up-to-date versions of those headers.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ichordev! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20740"

@ichordev
Copy link
Author

Removed trailing whitespace.

@thewilsonator
Copy link
Contributor

Would be nice to add a changelog entry for this

@ichordev
Copy link
Author

Would be nice to add a changelog entry for this

Will do!

@ichordev
Copy link
Author

ichordev commented Jan 22, 2025

I tried to generate the preview but it didn't work, so hopefully I did it correctly! Thought I'd have to write my name somewhere?

@ichordev
Copy link
Author

ichordev commented Jan 22, 2025

OK this time I actually staged the whole changelog and not half of it. 🤦‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants