Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'for signed integrals' appearing twice WithNaN in docs #10626

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

ichordev
Copy link
Contributor

Before it read:

For signed integrals, the reserved value is T.min. For signed integrals, the reserved value is T.max.

Now it reads:

For signed integrals, the reserved value is T.min. For unsigned integrals, the reserved value is T.max.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ichordev! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10626"

@thewilsonator thewilsonator merged commit a4d516a into dlang:master Jan 19, 2025
8 of 9 checks passed
@thewilsonator
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review:Trivial typos, formatting, comments Severity:Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants