Feat: non-destructive increase of a storage volume size #1122
+276
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamelessOne91
changed the title
5 tasks
|
Thank you for this PR @NamelessOne91! I'll try to test it in following days and give my feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #952 and #1017
This PR adds support for a non-destructive resize when a storage volume size is increased.
Shrinking a storage volume will still ultimately result in destroying the existing one and recreating it.
It would have been possible to handle both cases, shrinking and expanding, in the
UpdateContextfunction, but having aCustomizeDifffunction allows to correctly differentiate between a resource update and a destroy + add, notifying it to the user.