Fix/qemuagent #873
Closed
Fix/qemuagent #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See TestAccLibvirtDomain_NetworkInterfaceQemuGuestAgentStaticIP Testcase requires download of external vm image generated from GitHub workflow.
Uses libvirt.DomainInterfaceAddressesSrcAgent in call to virConn.DomainInterfaceAddresses
|
I have created a test version with this fix: https://github.com/remoe/terraform-provider-libvirt/releases/tag/untagged-fb1e891272fa09d2d159 It works on my side. ATTENTION: this not an official version. Use it only for testing. |
dmacvicar
requested changes
Oct 10, 2021
|
|
||
| interfaces, err = virConn.DomainInterfaceAddresses(domain, uint32(libvirt.DomainInterfaceAddressesSrcLease), 0) | ||
| var interfaces []libvirt.DomainInterface | ||
| interfaces, err = virConn.DomainInterfaceAddresses(domain, addrsrc, 0) | ||
| if err != nil { | ||
| switch err.(type) { | ||
| default: | ||
| return interfaces, fmt.Errorf("Error retrieving interface addresses: %s", err) | ||
| case libvirt.Error: | ||
| virErr := err.(libvirt.Error) |
There was a problem hiding this comment.
I think we can remove this cast here as it is not needed in this switch type.
|
Can anyone merge this with the above changes for next release? |
|
I have manually rebased and committed this. I don't like the 120M image for the test, so the test is pending and I opened #913 to revisit it. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements qemu-guest-agent interface query using go-libvirt interface.
Needed to query dhcp allocated IPs on bridged networks.
Testcase
I wanted to produce a decent reproducible test case so I generated an VM image (using alpine scripts) that runs qemu-guest-agent and configures a static IP that can be queried. See TestAccLibvirtDomain_NetworkInterfaceQemuGuestAgentStaticIP.
The VM test image in https://github.com/maseman/testvm-tflibvirt is generated with a workflow as a release asset. At ~100MB I thought it best NOT to add the file to terraform-provider-libvirt /testdata and instead setup a download in the testcase.
Alpine VMs like this (and with small overlay configurations) might be useful for other more complex test scenarios in the future.